Airline Mogul Forum

Airline Mogul => Bugs => Topic started by: Chavaquiah on November 03, 2008, 09:12:40 pm

Title: [Fixed] Batch removal of planes from leasing fails
Post by: Chavaquiah on November 03, 2008, 09:12:40 pm
Removing planes from the leasing market does not work unless it's done one by one. Selecting a few at a time and using the "Remove from lease" button results in a SQL error:

Code: [Select]
Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /var/www/vhosts/airlinemogul.com/httpdocs/airlinemogul/aircraft_market.php on line 691
This on top of a previously reported error where lease conditions cannot be changes:

Code: [Select]
Putting plane up for public lease.
Unknown column 'lease_to' in 'field list'
There was a problem when updating the lease terms.

Happening in World 14, Airline 8585.
Title: Re: Batch removal of planes from leasing fails
Post by: Air Elbonia on November 04, 2008, 02:27:04 am
I think i've fixed the latter, the former... should at a bare minimum provide a slightly more descriptive error message (which will help me fix it properly).
Title: Re: Batch removal of planes from leasing fails
Post by: Chavaquiah on November 04, 2008, 07:41:05 am
OK, there is some more information now. Also notice how, on the second step, a/c types are not displayed.

(http://img201.imageshack.us/img201/7421/err1uj8.jpg) (http://imageshack.us)

(http://img443.imageshack.us/img443/198/err2bl9.jpg) (http://imageshack.us)
(http://img443.imageshack.us/img443/err2bl9.jpg/1/w742.png) (http://g.imageshack.us/img443/err2bl9.jpg/1/)

(http://img443.imageshack.us/img443/4108/err3bb7.jpg) (http://imageshack.us)
(http://img443.imageshack.us/img443/err3bb7.jpg/1/w741.png) (http://g.imageshack.us/img443/err3bb7.jpg/1/)


Modifying lease conditions is already fixed.


Oh, BTW, there seems to have been a regression on the left navigation bar. Clicking both DOC and Airline Value take us to the finance screen instead ot view routes and rankings, as they used to these last few days.
Title: Re: Batch removal of planes from leasing fails
Post by: StephenM on November 04, 2008, 11:24:42 am
Will made a change to that file, it may have been an older version that he changed.
Title: Re: Batch removal of planes from leasing fails
Post by: Chavaquiah on November 04, 2008, 11:52:38 am
Hint: Version Control System.  ;)

Title: Re: Batch removal of planes from leasing fails
Post by: Air Elbonia on November 04, 2008, 11:59:52 am
we're verifying a version control system install..

anyways, stephen, that's the most recent version (all i did was make it display the detail of the error).

I'll see what i can do to fix this, if stephen hasn't, after work today.
Title: Re: Batch removal of planes from leasing fails
Post by: Chavaquiah on November 04, 2008, 12:16:48 pm
anyways, stephen, that's the most recent version (all i did was make it display the detail of the error).
Sorry for the confusion but my last comment was about the "Quick stat" panel (which I assume is an include). Somewhat unrelated to the mass removal bug.
Title: Re: Batch removal of planes from leasing fails
Post by: MrOrange on November 04, 2008, 01:13:26 pm
anyways, stephen, that's the most recent version (all i did was make it display the detail of the error).
Sorry for the confusion but my last comment was about the "Quick stat" panel (which I assume is an include). Somewhat unrelated to the mass removal bug.
Yeah, I noticed (and re-updated) that one too after some user requests. See, we do listen to user input :P

Now, Will, get that Version Control System going ;)
Title: Re: Batch removal of planes from leasing fails
Post by: StephenM on November 04, 2008, 02:50:34 pm
Now, Will, get that Version Control System going ;)

Its work in progress, slow progress but there is one outstanding issue for the moment.
Title: Re: [Fixed] Batch removal of planes from leasing fails
Post by: StephenM on November 05, 2008, 11:23:59 pm
Fixed, simple issue of having an extra pair of ()'s!
Title: Re: [Fixed] Batch removal of planes from leasing fails
Post by: Chavaquiah on November 05, 2008, 11:32:05 pm
Time to start pushing for a mass lease option? :lol:

Anyway, thanks. This makes using the aircraft market much easier.

There seems to be still a small glitch (see PM) but otherwise it's working fine.

Again, thanks.
Title: Re: [Fixed] Batch removal of planes from leasing fails
Post by: StephenM on November 05, 2008, 11:35:45 pm
There seems to be still a small glitch (see PM) but otherwise it's working fine.

Replied to.
Title: Re: [Fixed] Batch removal of planes from leasing fails
Post by: Chavaquiah on November 05, 2008, 11:43:17 pm
And fixed the last small problem, I see. It seems to be working just fine now.